Add Namespace
to List, Query, and Fetch vector responses
#52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@jseldess noticed that the Go client doesn't return an explicit
Namespace
with data plane operations. This would be helpful for the end user asNamespace
is configured when a user targets an index, so having theNamespace
associated with the specific operation would be useful for validating the namespace where the data was retrieved. Additionally, other SDKs such as TypeScript return namespace as a part of the response object.Solution
Namespace
as a field inFetchVectorsResponse
,ListVectorsResponse
, andQueryVectorsResponse
.We do not use
omitempty
forNamespace
as the""
namespace has meaning as the default.Type of Change
Test Plan
Make sure CI unit / integration tests are passing. Make fetch, query, or list operations and confirm the appropriate
Namespace
is returned depending on which index is targeted.